CI: Limit concurrency of Docu jobs #5535
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building tests on master, we normally let *all* of them complete not just the latest one, as that helps with pinpointing caused by merging PRs in parallel that then interact badly. But for the documentation job this is problematic: it can happen that we merge multiple PRs simultaneously, resulting in multiple concurrent CI jobs running on `master``. But the Docu job for the last merged PR may not be the last to finish. In that case, the job which actually finishes last "wins" and pushes its version of the documentation. As a result, the documentation does not reflect any changes from the last merged PRs (and possibly more). Even with the changes in this PR, there is still a problem when a PR CI job pushes a docs preview in concurrency to a CI job on master updating the docs.
fingolfin
added
CI
release notes: not needed
Member
|
Given that the documentation job only needs about 4-5 minutes, we could even try to disallow concurrent jobs from different branches, i.e. they would run sequentially in the order the jobs were requested. I think combining this together with just canceling intermediate jobs on PR branches (but not on master), would give us the same results as right now, but without the race conditions, and hopefully also without an enormous backlog in the job queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building tests on master, we normally let all of them complete not just the latest one, as that helps with pinpointing caused by merging PRs in parallel that then interact badly.
But for the documentation job this is problematic: it can happen that we merge multiple PRs simultaneously, resulting in multiple concurrent CI jobs running on `master``. But the Docu job for the last merged PR may not be the last to finish.
In that case, the job which actually finishes last "wins" and pushes its version of the documentation. As a result, the documentation does not reflect any changes from the last merged PRs (and possibly more).
Even with the changes in this PR, there is still a problem when a PR CI job pushes a docs preview in concurrency to a CI job on master updating the docs.